Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Rails/CurrentAttributesInstanceVariable #959

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomas-mcdonald
Copy link

Using instance variables in instances of ActiveSupport::CurrentAttributes carries a high risk of leaking state between requests since this state is not managed in the same way as the attributes interface. This new Cop will flag this issue.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Using instance variables in instances of ActiveSupport::CurrentAttributes
carries a high risk of leaking state between requests since this state is
not managed in the same way as the attributes interface.
@thomas-mcdonald
Copy link
Author

@koic do you think this is a reasonable cop to add? will finish the swing if this is likely to get merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant