[#78] Create EnumHash Cop #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
reviewed
Jul 24, 2019
santib
force-pushed
the
add-hashenum-cop
branch
2 times, most recently
from
48f2ecb
to
8808dab
Compare
|
Not needed now, but it would be nice to have an autocorrect this in the future. |
andyw8
reviewed
Jul 24, 2019
@andyw8 We splitted the work in two PRs because we didn't know if we were going to have time to do both and also to make code review easier. Here is the autocorrect PR #95 . Let us know if you prefer to have them being just one PR. Thanks for reviewing BTW 😄 |
brunvez
force-pushed
the
add-hashenum-cop
branch
2 times, most recently
from
a5ea0b2
to
69b69d0
Compare
Awesome. I think it's fine to have them as separate PRs. |
andyw8
reviewed
Jul 25, 2019
koic
reviewed
Jul 25, 2019
koic
reviewed
Jul 25, 2019
koic
reviewed
Jul 25, 2019
koic
reviewed
Jul 25, 2019
|
Thanks! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #78.
Implement EnumHash Cop.
Prefer hash syntax over array syntax for enum declarations.