Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #53] Fix a false positive for Rails/SaveBang #90

Merged
merged 1 commit into from Jul 22, 2019

Conversation

koic
Copy link
Member

@koic koic commented Jul 20, 2019

Fixes #53.

This PR fixes a false positive for Rails/SaveBang when implicitly return using finder method and creation method connected by ||.

And this PR updates .rubocop_todo.yml with rubocop --auto_gen_config to prevent the following offense.

% rubocop lib/rubocop/cop/rails/save_bang.rb
Inspecting 1 file
C

Offenses:

lib/rubocop/cop/rails/save_bang.rb:100:7: C: Metrics/ClassLength: Class
has too many lines. [164/159]
      class SaveBang < Cop ...
            ^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fixes rubocop#53.

This PR fixes a false positive for `Rails/SaveBang` when implicitly
return using finder method and creation method connected by `||`.

And this PR updates .rubocop_todo.yml with `rubocop --auto_gen_config`
to prevent the following offense.

```console
% rubocop lib/rubocop/cop/rails/save_bang.rb
Inspecting 1 file
C

Offenses:

lib/rubocop/cop/rails/save_bang.rb:100:7: C: Metrics/ClassLength: Class
has too many lines. [164/159]
      class SaveBang < Cop ...
            ^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected
```
@koic koic merged commit cdb7330 into rubocop:master Jul 22, 2019
@koic koic deleted the fix_a_false_positive_for_rails_save_bang branch July 22, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/SaveBang does not account for control flow
1 participant