Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve multiline semantics on Rails/Presence #817

Merged
merged 1 commit into from Oct 20, 2022

Conversation

ydah
Copy link
Member

@ydah ydah commented Oct 19, 2022

Similar issue: rubocop/rubocop#10784

Before

if a.present?
+^^^^^^^^^^^^^ Use `a.presence || b.to_f * 12.0` instead of `if a.present?
+  a
+else
+  b
+end`.
  a
else
  b
end

After

if a.present?
+^^^^^^^^^^^^^ Use `a.presence || b` instead of `if a.present? ... end`.
  a
else
  b
end

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • [-] Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • [-] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Similar issue: rubocop/rubocop#10784

Before
```diff
if a.present?
+^^^^^^^^^^^^^ Use `a.presence || b.to_f * 12.0` instead of `if a.present?
+  a
+else
+  b
+end`.
  a
else
  b
end
```

After
```diff
if a.present?
+^^^^^^^^^^^^^ Use `a.presence || b` instead of `if a.present? ... end`.
  a
else
  b
end
```
@koic koic merged commit d7db4d1 into rubocop:master Oct 20, 2022
@koic
Copy link
Member

koic commented Oct 20, 2022

Thanks!

@ydah ydah deleted the change/presence branch October 20, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants