Make Rails/RedundantReceiverInWithOptions and Rails/ReversibleMigration aware of numblock
#754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation` aware of numblock This PR Make `Rails/RedundantReceiverInWithOptions` and `Rails/ReversibleMigration` cops aware of numbered block parameter. `Rails/ActionFilter` and `Rails/RakeEnvironment` cops have block arguments, so numblock operation is unnecessary. `Rails/IndexBy` and `Rails/IndexWith` cops is a slightly more complicated operation using multiple block arguments. It'll take care of it another time using `rubocop:todo` comment because I think it's a really rare case.
koic
deleted the
make_redundant_receiver_in_with_options_and_reversible_migration_aware_of_numblock
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Rails/RedundantReceiverInWithOptionsandRails/ReversibleMigrationcops aware of numbered block parameter.Rails/ActionFilterandRails/RakeEnvironmentcops have block arguments, so numblock operation is unnecessary.Rails/IndexByandRails/IndexWithcops is a slightly more complicated operation using multiple block arguments.It'll take care of it another time using
rubocop:todocomment because I think it's a really rare case.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.