Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #707] Fix an error when a variable is passed to has_many or has_one with double splat #708

Merged

Conversation

nobuyo
Copy link
Contributor

@nobuyo nobuyo commented May 31, 2022

Fixes #707.

RuboCop cannot determine whether dependent is included if a variable is passed,
but I thought it was fine to leave it as is to register the offense to make people aware of it.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

…hen a variable is passed to has_many or has_one with double splat
@koic koic merged commit fbba9b2 into rubocop:master Jun 1, 2022
@koic
Copy link
Member

koic commented Jun 1, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error occurred while Rails/HasManyOrHasOneDependent cop was inspecting
2 participants