Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jobs & mailers to default filter/action callbacks cops #705

Merged
merged 1 commit into from May 31, 2022

Conversation

ojab
Copy link
Contributor

@ojab ojab commented May 27, 2022

They use the same filter/action API.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • n/a Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • n/a If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@ojab ojab force-pushed the patch-1 branch 3 times, most recently from b2a517b to c6c4fda Compare May 27, 2022 17:37
@ojab ojab marked this pull request as ready for review May 27, 2022 17:45
@koic
Copy link
Member

koic commented May 27, 2022

Can you provide a link to the official documentation on these jobs and mailers filter / action API?

@ojab ojab changed the title Add jobs & mailers to default Rails/ActionFilter config Add jobs & mailers to default filter/action callbacks cops May 27, 2022
@ojab ojab force-pushed the patch-1 branch 2 times, most recently from 5e3e0c6 to 91811bd Compare May 27, 2022 18:59
They use the same `filter`/`action` API.
@ojab
Copy link
Contributor Author

ojab commented May 27, 2022

https://edgeguides.rubyonrails.org/action_mailer_basics.html#action-mailer-callbacks and actionmailer/lib/action_mailer/base.rb: include AbstractController::Callbacks
Yeah, thinko about jobs, API is different there.

@koic koic merged commit 097682d into rubocop:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants