Fix TransactionExitStatement in_rescue? Logic

[dorkrawk]

The old logic for in_rescue? in the TransactionExitStatement case missed situations where a transaction contained an exit outside of a rescue. For example:

ApplicationRecord.transaction do
  return if user.active?
rescue
  pass
end

This fix adds a new node matcher to find exit statements within the rescue body.

---

Before submitting the PR make sure the following are checked:

• The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
• Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
• The PR relates to only one subject with a clear title
  and description in grammatically correct, complete sentences.
• If this is a new cop, consider making a corresponding update to the Rails Style Guide.

[koic]

It seems like a typo.

Suggested change

	* Fixes a false negative where the `in_rescue?` check would bypass situations where the return was inside a transaction but ouside of a rescue. ([@dorkrawk][])
	* Fixes a false negative where the `in_rescue?` check would bypass situations where the return was inside a transaction but outside of a rescue. ([@dorkrawk][])

And can you add the PR address?

* [#695](https://github.com/rubocop/rubocop-rails/pull/695): Fixes a false negative where the `in_rescue?` check would bypass situations where the return was inside a transaction but outside of a rescue. ([@dorkrawk][])

[koic]

Can you indent it?

Suggested change

	return if user.active?
	^^^^^^ Exit statement `return` is not allowed. Use `raise` (rollback) or `next` (commit).
	return if user.active?
	^^^^^^ Exit statement `return` is not allowed. Use `raise` (rollback) or `next` (commit).

[koic]

Can you move it? The following is an example:

        def_node_search :exit_statements, <<~PATTERN
          ({return | break | send nil? :throw} ...)
        PATTERN

+       def_node_matcher :rescue_body_return_node?, <<~PATTERN
+         (:resbody ...
+           ...
+           ({return | break | send nil? :throw} ...)
+           ...
+         )
+       PATTERN

        def on_send(node)

[dorkrawk]

@koic Ok, I've made the requested updates and re-squashed the commits

[koic]

Thanks!