Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Rails/DynamicFindBy #346

Merged
merged 1 commit into from Sep 14, 2020

Commits on Sep 13, 2020

  1. Fix a false positive for Rails/DynamicFindBy

    This PR fixes a false positive for `Rails/DynamicFindBy`
    when any of the arguments are splat argument.
    
    ```console
    % cat example.rb
    find_by_scan(*args)
    
    % bundle exec rubocop -a example.rb
    (snip)
    
    Inspecting 1 file
    E
    
    Offenses:
    
    example.rb:1:1: C: [Corrected] Rails/DynamicFindBy: Use find_by instead
    of dynamic find_by_scan.
    find_by_scan(*args)
    ^^^^^^^^^^^^^^^^^^^
    example.rb:1:15: E: Lint/Syntax: unexpected token tSTAR
    (Using Ruby 2.7 parser; configure using TargetRubyVersion parameter,
    under AllCops)
    find_by(scan: *args)
                  ^
    
    1 file inspected, 2 offenses detected, 1 offense corrected
    
    % cat example.rb
    find_by(scan: *args)
    
    % ruby -c example.rb
    example.rb:1: syntax error, unexpected *
    find_by(scan: *args)
    ```
    koic committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    01036ab View commit details
    Browse the repository at this point in the history