Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Rails/UniqBeforePluck cop as unsafe auto-correction #331

Merged

Commits on Aug 17, 2020

  1. Mark Rails/UniqBeforePluck cop as unsafe auto-correction

    Follow rubocop#320 and rubocop/rubocop#8529.
    
    This PR changes the mark of `Rails/UniqBeforePluck` from `Safe: false`
    to `SafeAutoCorrect: false`.
    
    False positives to detection are not a concern. Only worry about
    incompatibilities with auto-correction.
    
    Below is an excerpt from the official document.
    
    > * Safe (true/false) - indicates whether the cop can yield false
    > positives (by design) or not.
    >
    > * SafeAutoCorrect (true/false) - indicates whether the auto-correct a cop
    > does is safe (equivalent) by design. If a cop is unsafe its auto-correct
    > automatically becomes unsafe as well.
    
    https://docs.rubocop.org/rubocop/0.89/usage/auto_correct.html#safe-auto-correct
    koic committed Aug 17, 2020
    Copy the full SHA
    523ddfb View commit details
    Browse the repository at this point in the history