Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails/EnumKeywordArgs cop #1239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxprokopiev
Copy link

@maxprokopiev maxprokopiev commented Feb 16, 2024

This PR adds a new cop called Rails/EnumKeywordArgs.

This cop checks for the use of deprecated keyword arguments in enums. See more in #1238

Style guide PR: rubocop/rails-style-guide#356


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Defining enums with keyword arguments is deprecated
and will be removed in Rails 7.3.
@maxprokopiev maxprokopiev marked this pull request as ready for review February 16, 2024 11:04
@maxprokopiev
Copy link
Author

@ghiculescu
Copy link
Contributor

see rubocop/rails-style-guide#356 (comment)

A linter would still be helpful if it helps people autocorrect so they can migrate to the new API automatically.

@maxprokopiev
Copy link
Author

reopening this one since there seem to be some demand to have a linter, but not an entry to the style guide

@maxprokopiev maxprokopiev reopened this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants