[Fix #1039] Deprecate Rails/ActionFilter cop
#1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
changed the title
Rails/ActionFilterRails/ActionFilter cop
Fixes rubocop#1039. This PR deprecates `Rails/ActionFilter` cop. Because the `*_filter` methods were removed in Rails 4.2, and that Rals version is no longer supported by RuboCop Rails. This cop will be removed in RuboCop Rails 3.0.
koic
force-pushed
the
deprecate_rails_action_filter_cop
branch
from
e051432
to
1874ad8
Compare
|
Thanks! |
|
Ah, that's a good idea! I think it can be disabled right away. |
koic
added a commit
that referenced
this pull request
Oct 13, 2023
Follow up #1149 (comment). This commit disables `Rails/ActionFilter` cop.
mjankowski
added a commit
to mjankowski/standard-rails
that referenced
this pull request
May 31, 2024
History in standard-rails: - Disabled in initial rules import - Enabled in bulk rails rule enable commit This cop is both disabled by default and deprecated in rubocop-rails: rubocop/rubocop-rails#1149 Rationale is that the cop is only relevant to Rails versions so early they are no longer supported by rubocop-rails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1039.
This PR deprecates
Rails/ActionFiltercop. Because the*_filtermethods were removed in Rails 4.2, and that Rals version is no longer supported by RuboCop Rails. This cop will be removed in RuboCop Rails 3.0.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.