New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Rails/SaveBang as unsafe autocorrect #101

Merged

koic merged 1 commit into rubocop:master from prathamesh-sonpatki:rails-bang-unsafe

Aug 8, 2019

Commits on Aug 7, 2019

Mark Rails/SaveBang as unsafe autocorrect

We faced an issue where our custom `update` method call was changed to `update!` but the method name remained same in the method definition.

```ruby
def update
end

update!
```

```ruby
def update
end

update
```

So the cop is not safe for auto correct.

prathamesh-sonpatki committed Aug 7, 2019