Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #448] Fix a false positive for Performance/RedundantBlockCall #449

Conversation

koic
Copy link
Member

@koic koic commented Mar 22, 2024

Fixes #448.

This PR fixes a false positive for Performance/RedundantBlockCall when using block.call with block argument.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…kCall`

Fixes rubocop#448.

This PR fixes a false positive for `Performance/RedundantBlockCall`
when using `block.call` with block argument.
@koic koic force-pushed the fix_false_positive_for_performance_redundant_block_call branch from 6cfb3fe to 0d98285 Compare March 25, 2024 02:39
@koic koic merged commit 9d28120 into rubocop:master Mar 29, 2024
14 checks passed
@koic koic deleted the fix_false_positive_for_performance_redundant_block_call branch March 29, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance/RedundantBlockCall produces invalid code
1 participant