Add new Performance/CollectionLiteralInMethod
cop
#303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #71
This PR adds new
Performance/CollectionLiteralInMethod
cop.This cop detects
Array
andHash
literal used in method definitions, including singleton methods.It prevents allocating collections every time the method is used.
This PR also fixed code offenses in codebase found by the new cop.
The new rule can be considered a stricter version of
Performance/CollectionLiteralInLoop
cop that allows literals in method as long as those are used outside of loop.Benchmark
The below benchmark showed that using constant in method is
48-52%
faster than literal in method.Ruby 2.7.6
Ruby 3.1.2
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.