Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jruby instead of circleci/jruby images #302

Closed
wants to merge 2 commits into from

Conversation

koic
Copy link
Member

@koic koic commented Sep 2, 2022

This update is similar to rubocop/rubocop#10326.
https://hub.docker.com/r/circleci/jruby hasn't been updated in a while.

The quickest way to get new resource is to be able to use official image.
https://hub.docker.com/_/jruby


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This update is similar to rubocop/rubocop#10326.
https://hub.docker.com/r/circleci/jruby hasn't been updated in a while.

The quickest way to get new resource is to be able to use official image.
https://hub.docker.com/_/jruby
@koic koic force-pushed the use_official_jruby_image branch 4 times, most recently from 33c0c16 to 7abac77 Compare March 22, 2023 08:46
@koic
Copy link
Member Author

koic commented Feb 15, 2024

This issue has been resolved in #398.

@koic koic closed this Feb 15, 2024
@koic koic deleted the use_official_jruby_image branch February 15, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant