Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Performance/Sum auto-correction as unsafe and extend documentation #270

Merged
merged 1 commit into from Nov 16, 2021

Commits on Nov 16, 2021

  1. Mark Performance/Sum auto-correction as unsafe and extend documenta…

    …tion
    
    The documentaion of `Performance/Sum` talked about setting
    `SafeAutoCorrect: true` for the cop, but Rubocop complained:
    
    ```
    Warning: Performance/Sum does not support SafeAutoCorrect parameter.
    
    Supported parameters are:
    
      - Enabled
    
    ```
    
    so we add the `SafeAutoCorrect` option to the cop's defaults
    and thereby mark it as (partially) unsafe.
    
    This is NOT a change in behavior: The cop will still perform all
    safe auto-corrections when using `-a`, and also (by default)
    perform all unsafe auto-corrections when using `-A`.
    
    Furthermore we extend the documentation in order to make it even more
    clear in _which_ cases auto-correction is unsafe, and _why_.
    leoarnold committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    b1eb508 View commit details
    Browse the repository at this point in the history