Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unmark AutoCorrect: false from Performance/StringInclude #263

Merged
merged 1 commit into from Oct 30, 2021
Merged

Unmark AutoCorrect: false from Performance/StringInclude #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/change_unmark_autocorrect_false_from_performance_string_include.md
View file
Open in desktop
@@ -0,0 +1 @@
* [#263](https://github.com/rubocop/rubocop-performance/pull/263): Unmark `AutoCorrect: false` from `Performance/StringInclude`. ([@koic][])
2 changes: 1 addition & 1 deletion config/default.yml
View file
Open in desktop
Expand Up @@ -309,9 +309,9 @@ Performance/StartWith:
Performance/StringInclude:
Description: 'Use `String#include?` instead of a regex match with literal-only pattern.'
Enabled: 'pending'
AutoCorrect: false
SafeAutoCorrect: false
VersionAdded: '1.7'
VersionChanged: '1.12'

Performance/StringReplacement:
Description: >-
Expand Down
12 changes: 1 addition & 11 deletions docs/modules/ROOT/pages/cops_performance.adoc
View file
Open in desktop
Expand Up @@ -1848,7 +1848,7 @@ for receiver is multiline string.
| Yes
| Yes (Unsafe)
| 1.7
| -
| 1.12
|===

This cop identifies unnecessary use of a regex where
Expand All @@ -1872,16 +1872,6 @@ This cop's offenses are not safe to auto-correct if a receiver is nil.
'abc'.include?('ab')
----

=== Configurable attributes

|===
| Name | Default value | Configurable values

| AutoCorrect
| `false`
| Boolean
|===

== Performance/StringReplacement

|===
Expand Down