Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #252] Fix an incorrect auto-correct for Performance/UnfreezeString #253

Conversation

koic
Copy link
Member

@koic koic commented May 25, 2021

Fixes #252.

This PR fixes an incorrect auto-correct for Performance/UnfreezeString when invoking a method after String.new with a string.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…eezeString`

Fixes rubocop#252.

This PR fixes an incorrect auto-correct for `Performance/UnfreezeString`
when invoking a method after `String.new` with a string.
@koic koic merged commit f4971a2 into rubocop:master May 26, 2021
@koic koic deleted the fix_incorrect_autocorrect_for_performance_unfreeze_string branch May 26, 2021 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnfreezeString autocorrect incorrectly handles .force_encoding
1 participant