[Fix #249] Fix a false positive for Performance/RedundantStringChars
#250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
@koic This is not a |
|
Thanks for your feedback. This PR ensures safety by focusing on safe methods. In other words, the cop name is redundant string |
…ngChars` Fixes rubocop#249. This PR fixes a false positive for `Performance/RedundantStringChars` when using `str.chars.last` and `str.chars.drop`.
koic
force-pushed
the
fix_false_positive_for_redundant_string_chars
branch
from
4f3b5c9
to
bc3a9fa
Compare
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
Nov 21, 2022
…ngChars` Fixes rubocop#313. This PR fixes a false negative for `Performance/RedundantStringChars` when using `str.chars.last` without argument. Report rubocop#249 has `str.chars.last(2)` argument. rubocop#250 mistakenly changed even without arguments `str.chars.last`.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249.
This PR fixes a false positive for
Performance/RedundantStringCharswhen usingstr.chars.lastandstr.chars.drop.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.