[Fix #163] Detect array indexes for Performance/Detect
#167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSarCasm
reviewed
Sep 11, 2020
dvandersluis
force-pushed
the
detect-indexed
branch
3 times, most recently
from
99f79c6
to
0ac774b
Compare
dvandersluis
commented
Sep 11, 2020
| @@ -30,5 +30,6 @@ Gem::Specification.new do |s| | |||
| } | |||
|
|
|||
| s.add_runtime_dependency('rubocop', '>= 0.87.0') | |||
| s.add_runtime_dependency('rubocop-ast', '>= 0.4.0') | |||
There was a problem hiding this comment.
This was necessary to use Sets inside node patterns on ruby 2.4. Please see rubocop/rubocop-ast#107 for more details.
koic
reviewed
Sep 14, 2020
For example, `[1, 2, 3].detect{ ... }[0]` will now be caught and corrected by the cop.
dvandersluis
force-pushed
the
detect-indexed
branch
from
a9d6377
to
627f47d
Compare
|
@koic are anything other changes necessary here? |
|
Yeah, this looks good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1, 2, 3].detect{ ... }[0]and[1, 2, 3].detect{ ... }[-1]will now be caught and corrected by the cop as if they werefirstandlast.Fixes #163.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.