Merge pull request #266 from koic/false_negative_for_performance_redu…

…ndant_block_call

[Fix #261] Fix a false negative for `Performance/RedundantBlockCall`

changelog/fix_false_negative_for_performance_redundant_block_call.md

@@ -0,0 +1 @@
+* [#261](https://github.com/rubocop/rubocop-performance/issues/261): Fix a false negative for `Performance/RedundantBlockCall` when using `block.call` in a class method'. ([@koic][])

lib/rubocop/cop/performance/redundant_block_call.rb

@@ -55,6 +55,7 @@ def on_def(node)
             end
           end
         end
+        alias on_defs on_def
 
         private
 

spec/rubocop/cop/performance/redundant_block_call_spec.rb

@@ -31,6 +31,21 @@ def method(&block)
     RUBY
   end
 
+  it 'registers and corrects an offense when using `block.call` in a class method' do
+    expect_offense(<<~RUBY)
+      def self.method(&block)
+        block.call
+        ^^^^^^^^^^ Use `yield` instead of `block.call`.
+      end
+    RUBY
+
+    expect_correction(<<~RUBY)
+      def self.method(&block)
+        yield
+      end
+    RUBY
+  end
+
   it 'registers and autocorrects an offense when `block.call` with arguments' do
     expect_offense(<<~RUBY)
       def method(&block)