Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Mark
Performance/Sum
auto-correction as unsafe and extend documenta…
…tion The documentaion of `Performance/Sum` talked about setting `SafeAutoCorrect: true` for the cop, but Rubocop complained: ``` Warning: Performance/Sum does not support SafeAutoCorrect parameter. Supported parameters are: - Enabled ``` so we add the `SafeAutoCorrect` option to the cop's defaults and thereby mark it as (partially) unsafe. This is NOT a change in behavior: The cop will still perform all safe auto-corrections when using `-a`, and also (by default) perform all unsafe auto-corrections when using `-A`. Furthermore we extend the documentation in order to make it even more clear in _which_ cases auto-correction is unsafe, and _why_.
- Loading branch information
Showing
7 changed files
with
109 additions
and
79 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
* [#270](https://github.com/rubocop/rubocop-performance/pull/270): Mark `Performance/Sum` auto-correction as unsafe and extend documentation. ([@leoarnold][]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters