Support Prism as a Ruby parser #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
support_prism
branch
2 times, most recently
from
2a74761
to
0d3ddbc
Compare
Follow up rubocop/rubocop-ast#277 There are no changes to the implementation, but the required dependency version of RuboCop AST will be updated. It would be more rational than adding new dependency on `gem 'rubocop-ast', '>= 1.31.1'` in the Gemfile just to bump up the minor version. RuboCop Minitest now ensures that `RuboCop::AST::ProcessedSource` used in tests is aware of `parser_engine` parameter. Tests for RuboCop AST with Prism as the backend can be run as follows: ```console bundle exec rake prism_test ``` The above is the shortcut alias for: ```console PARSER_ENGINE=parser_prism bundle exec rake test ``` RuboCop works on Ruby versions 2.7+, but since Prism only targets parsing for Ruby 3.3+, `internal_investigation` Rake task will not be executed. This task is only run with the Parser gem, which can parse Ruby versions 2.0+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up rubocop/rubocop-ast#277
There are no changes to the implementation, but the required dependency version of RuboCop AST will be updated. It would be more rational than adding new dependency on
gem 'rubocop-ast', '>= 1.31.1'in the Gemfile just to bump up the minor version.RuboCop Minitest now ensures that
RuboCop::AST::ProcessedSourceused in tests is aware ofparser_engineparameter.Tests for RuboCop AST with Prism as the backend can be run as follows:
bundle exec rake prism_testThe above is the shortcut alias for:
PARSER_ENGINE=parser_prism bundle exec rake testRuboCop works on Ruby versions 2.7+, but since Prism only targets parsing for Ruby 3.3+,
internal_investigationRake task will not be executed. This task is only run with the Parser gem, which can parse Ruby versions 2.0+.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.