Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #256] Fix a false positive for Minitest/RefuteEqual #257

Merged

Conversation

koic
Copy link
Member

@koic koic commented Aug 30, 2023

Fixes #256.

This PR fixes a false positive for Minitest/RefuteEqual when assert(!expected == actual).


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Fixes rubocop#256.

This PR fixes a false positive for `Minitest/RefuteEqual`
when `assert(!expected == actual)`.
@koic koic merged commit f53ede0 into rubocop:master Sep 1, 2023
10 checks passed
@koic koic deleted the fix_a_false_positive_for_minitest_refute_equal branch September 1, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refute_equal tests and refute_equal matcher are both wrong
1 participant