Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Minitest/AssertPredicate and Minitest/RefutePredicate cops #161

Conversation

koic
Copy link
Member

@koic koic commented Mar 1, 2022

This PR adds new Minitest/AssertPredicate and Minitest/RefutePredicate cops.

Minitest/AssertPredicate cop

This cop enforces the test to use assert_predicate
instead of using assert(obj.a_predicate_method?).

# bad
assert(obj.one?)
assert(obj.one?, 'message')

# good
assert_predicate(obj, :one?)
assert_predicate(obj, :one?, 'message')

Minitest/RefutePredicate cop

This cop enforces the test to use refute_predicate
instead of using refute(obj.a_predicate_method?).

# bad
refute(obj.one?)
refute(obj.one?, 'message')

# good
refute_predicate(obj, :one?)
refute_predicate(obj, :one?, 'message')

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the add_new_minitest_assert_predicate_refute_predicate_cops branch 2 times, most recently from 17bdbcd to 13cd764 Compare March 2, 2022 03:37
This PR adds new `Minitest/AssertPredicate` and `Minitest/RefutePredicate` cops.

## `Minitest/AssertPredicate` cop

This cop enforces the test to use `assert_predicate`
instead of using `assert(obj.a_predicate_method?)`.

```ruby
# bad
assert(obj.one?)
assert(obj.one?, 'message')

# good
assert_predicate(obj, :one?)
assert_predicate(obj, :one?, 'message')
```

## `Minitest/RefutePredicate` cop

This cop enforces the test to use `refute_predicate`
instead of using `refute(obj.a_predicate_method?)`.

```ruby
# bad
refute(obj.one?)
refute(obj.one?, 'message')

# good
refute_predicate(obj, :one?)
refute_predicate(obj, :one?, 'message')
```
@koic koic force-pushed the add_new_minitest_assert_predicate_refute_predicate_cops branch from 13cd764 to 4c38d48 Compare March 2, 2022 03:43
@koic koic merged commit 3f41b4c into rubocop:master Mar 12, 2022
@koic koic deleted the add_new_minitest_assert_predicate_refute_predicate_cops branch March 12, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant