Merge pull request #145 from koic/mark_minitest_assert_empty_literal_…

…as_safe_autocorrection Mark `Minitest/AssertEmptyLiteral` as safe auto-correction
rubocop · Oct 3, 2021 · 6ddf6f7 · 6ddf6f7
2 parents b177996 + 50e790f
commit 6ddf6f7
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## master (unreleased)
 
+### Bug fixes
+
+* [#144](https://github.com/rubocop/rubocop-minitest/pull/144): Mark `Minitest/AssertEmptyLiteral` as safe auto-correction. ([@koic][])
+
 ## 0.15.1 (2021-09-26)
 
 ### Bug fixes

diff --git a/config/default.yml b/config/default.yml
@@ -11,9 +11,8 @@ Minitest/AssertEmpty:
   VersionAdded: '0.2'
 
 Minitest/AssertEmptyLiteral:
-  Description: 'This cop enforces the test to use `assert_empty` instead of using `assert([], object)` or `assert({}, object)`.'
+  Description: 'This cop enforces the test to use `assert_empty` instead of using `assert_equal([], object)`.'
   Enabled: true
-  SafeAutoCorrect: false
   VersionAdded: '0.5'
   VersionChanged: '0.11'
 

diff --git a/docs/modules/ROOT/pages/cops_minitest.adoc b/docs/modules/ROOT/pages/cops_minitest.adoc
@@ -39,13 +39,13 @@ assert_empty(object, 'message')
 
 | Enabled
 | Yes
-| Yes (Unsafe)
+| Yes
 | 0.5
 | 0.11
 |===
 
 This cop enforces the test to use `assert_empty`
-instead of using `assert_equal([], object)`.
+instead of using `assert_equal([], object)` or `assert_equal({}, object)`.
 
 === Examples
 

diff --git a/lib/rubocop/cop/minitest/assert_empty_literal.rb b/lib/rubocop/cop/minitest/assert_empty_literal.rb
@@ -4,7 +4,7 @@ module RuboCop
   module Cop
     module Minitest
       # This cop enforces the test to use `assert_empty`
-      # instead of using `assert_equal([], object)`.
+      # instead of using `assert_equal([], object)` or `assert_equal({}, object)`.
       #
       # @example
       #   # bad