Improve error message for invalid parser_engine value
#286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
fix-parser-engine-error-message
branch
2 times, most recently
from
6e46cdc
to
91e1616
Compare
|
It seems to be issues with |
|
Yes, sorry. I already force-pushed. |
|
I wonder if we shouldn't convert strings to keywords automatically here (if passed), as it's not a big deal. |
Earlopain
force-pushed
the
fix-parser-engine-error-message
branch
from
91e1616
to
9e3a92a
Compare
|
That makes sense to me. Reverted most of the error message changes since they are now unnecessary and made it to instead accept strings as well. |
bbatsov
reviewed
Mar 8, 2024
Earlopain
force-pushed
the
fix-parser-engine-error-message
branch
from
9e3a92a
to
2f0ea83
Compare
|
Released in v1.31.2, thanks! |
|
I had initially decided to accept only symbol argument, designing it would lead to better performance through consistency. But, currently, I think the convenience of accepting both string and symbol argument might be more beneficial. Let's accept both 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parserdoesn't exist, it must beparser_whitequark. In addition, this only accepts symbols.When passing a string, this would previously print
The keyword argument `parser_engine` accepts `parser` or `parser_prism`, but `parser_prism` was passed.. Useinspectto clearly show what you did wrong.The new error message looks like this:
The keyword argument `parser_engine` accepts `:parser_whitequark` or `:parser_prism`, but `"parser_prism"` was passed..