Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prism as a runtime dependency #283

Closed
wants to merge 1 commit into from
Closed

Remove prism as a runtime dependency #283

wants to merge 1 commit into from

Conversation

marcandre
Copy link
Contributor

Fixes #282

@koic
Copy link
Member

koic commented Mar 1, 2024

It is mentioned below, it seems better to hold off on making a decision to remove it for now:
#282 (comment)

If the decision is made to remove it, it would likely require adjustments not only to the removing dependency, also to issues surrounding Prism's loading and documentation. It might be better if I handle it. Thank you.

@koic
Copy link
Member

koic commented Mar 1, 2024

I've opened #285. It addresses users who don't have Prism installed, indicating through warning and documentation that Prism needs to be installed separately.

@bbatsov
Copy link
Contributor

bbatsov commented Mar 1, 2024

Addressed by #285.

@bbatsov bbatsov closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experimental Prism feature listed as runtime dependency
3 participants