Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new cop offense (for green ci) #266

Merged
merged 1 commit into from May 21, 2023
Merged

Fix new cop offense (for green ci) #266

merged 1 commit into from May 21, 2023

Conversation

pirj
Copy link
Member

@pirj pirj commented May 21, 2023 •
edited

see https://github.com/rubocop/rubocop-ast/actions/runs/5039437879/jobs/9037577956

 rubocop-ast.gemspec:38:3: C: Gemspec/DevelopmentDependencies: Specify development dependencies in Gemfile.
  s.add_development_dependency('bundler', '>= 1.15.0', '< 3.0')
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```

@pirj
Fix new cop offense
6e499b1 
see https://github.com/rubocop/rubocop-ast/actions/runs/5039437879/jobs/9037577956

 rubocop-ast.gemspec:38:3: C: Gemspec/DevelopmentDependencies: Specify development dependencies in Gemfile.
  s.add_development_dependency('bundler', '>= 1.15.0', '< 3.0')
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@pirj
Copy link
Member Author

pirj commented May 21, 2023 •
edited

mingw segfault 🤷

@marcandre marcandre merged commit d801fdf into rubocop:master May 21, 2023
17 of 18 checks passed
@marcandre
Copy link
Contributor

mingw segfault 🤷

Yeah, it's been doing that for ages actually, I haven't investigated 😅

Thanks for the PR

@pirj pirj deleted the fix-ci branch May 21, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pirj @marcandre