Fix an error when parsing non UTF-8 frozen string #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the following `FrozenError` when parsing non UTF-8 frozen string:
```console
$ cat example.rb
# encoding: ascii-8bit
# frozen_string_literal: true
require 'rubocop-ast'
RuboCop::AST::ProcessedSource.new('true', 3.2)
```
```console
$ ruby example.rb
/Users/koic/.rbenv/versions/3.2.1/lib/ruby/gems/3.2.0/gems/rubocop-ast-1.28.0/lib/rubocop/ast/processed_source.rb:30:
in `force_encoding': can't modify frozen String: "true" (FrozenError)
from /Users/koic/.rbenv/versions/3.2.1/lib/ruby/gems/3.2.0/gems/rubocop-ast-1.28.0/lib/rubocop/ast/processed_source.rb:30:
in `initialize'
from example.rb:6:in `new'
from example.rb:6:in `<main>'
```
|
The master brach of RuboCop has been dropped Ruby 2.6 runtime support. So |
|
Cool, thanks |
|
Thanks for the quick release! |
koic
added a commit
to koic/rubocop
that referenced
this pull request
Jul 24, 2023
This PR makes aware of `Style/RedundantArgument` aware of `exit` and `exit!`. It require RuboCop AST 1.28.1+ that includes rubocop/rubocop-ast#262.
8 tasks
bbatsov
pushed a commit
to rubocop/rubocop
that referenced
this pull request
Jul 24, 2023
This PR makes aware of `Style/RedundantArgument` aware of `exit` and `exit!`. It require RuboCop AST 1.28.1+ that includes rubocop/rubocop-ast#262.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following
FrozenErrorwhen parsing non UTF-8 frozen string: