Rename RuboCop::AST::Token#regexp_dot? to RuboCop::AST::Token#regexp_dots
#236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xp_dots` Follow up rubocop#235 (comment). This PR renames `RuboCop::AST::Token#regexp_dot?` to `RuboCop::AST::Token#regexp_dots`. It's been determined that it doesn't need to be an alias because it's the API that has just been released and isn't widespread.
koic
force-pushed
the
rename_regexp_dot_to_regexp_dots
branch
from
757cc22
to
1ed6f0c
Compare
|
Cool, thanks. Released as 1.19.1. I simplified the Changelog too. |
|
Great! Thank you Marc-André! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #235 (comment).
This PR renames
RuboCop::AST::Token#regexp_dot?toRuboCop::AST::Token#regexp_dots.It's been determined that it doesn't need to be an alias because it's the API that has just been released and isn't widespread.