Make RegexpNode aware of fixed-encoding regopt
#230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcandre Can you review this PR? |
|
@marcandre ping :-) |
dvandersluis
reviewed
Aug 5, 2022
dvandersluis
approved these changes
Aug 5, 2022
Resolves rubocop/rubocop#10552. This PR makes `RegexpNode` aware of fixed-encoding regopt.
koic
force-pushed
the
fix_regexp_node_aware_of_fixed_encoding_regopt
branch
from
32030c9
to
6c9cd77
Compare
|
Sorry I missed the notifications @koic |
koic
added a commit
to rubocop/rubocop
that referenced
this pull request
Aug 8, 2022
Follow up rubocop/rubocop-ast#230 and fixes #10552. This commit fixes a false positive for `Lint/OutOfRangeRegexpRef` when using fixed-encoding regopt.
WJWH
pushed a commit
to WJWH/rubocop
that referenced
this pull request
Aug 8, 2022
Follow up rubocop/rubocop-ast#230 and fixes rubocop#10552. This commit fixes a false positive for `Lint/OutOfRangeRegexpRef` when using fixed-encoding regopt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rubocop/rubocop#10552.
This PR makes
RegexpNodeaware of fixed-encoding regopt.