Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #208] Update MethodDispatchNode#block_literal? to return true for numblocks #209

Merged
merged 1 commit into from Sep 28, 2021
Merged

[Fix #208] Update MethodDispatchNode#block_literal? to return true for numblocks #209

merged 1 commit into from Sep 28, 2021

Conversation

dvandersluis
Copy link
Member

@dvandersluis dvandersluis commented Sep 15, 2021 •
edited

If a send node has a numblock as a parent, block_literal? returns false, but this changes it to treat numblocks the same as regular blocks. This also makes send_node.block_node return a numblock if applicable.

Fixes #208.

@dvandersluis dvandersluis mentioned this pull request Sep 15, 2021
Merged
8 tasks
koic
koic reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@dvandersluis
Copy link
Member Author

@marcandre @koic can this be released?

@dvandersluis
Copy link
Member Author

@marcandre ping!

@marcandre marcandre merged commit ceb3d1b into rubocop:master Sep 28, 2021
@marcandre
Copy link
Contributor

Thanks for the ping.
Releasing from CdMx airport 😅

@marcandre
Copy link
Contributor

Done, sorry for the delay :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koic koic koic approved these changes

@marcandre marcandre Awaiting requested review from marcandre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

send_node.block_node does not handle numblocks
3 participants
@dvandersluis @marcandre @koic