Revert "Temporarily disable rubocop 0.92 specs in CI" #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f4edb96.
|
@marcandre I guess we need a backport for v0.92 (or v0.93?) in order to make the tests there pass? |
|
You'll have to bump 0.92 => next RuboCop version (and we'll merge when it is released) |
I don't think we can do much tbh. It's ok, it is unlikely we'll break compatibility in a real fashion anyways. |
|
Is this still needed? |
|
Ideally yes. I'll try tweaking things in #264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #198
Re-enables running rubocop 0.92's tests in CI.