Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parent_module_name #177

Merged
merged 3 commits into from May 26, 2021
Merged

Improve parent_module_name #177

merged 3 commits into from May 26, 2021

Commits on Apr 5, 2021

  1. Fix unexpected non-local exits on Rubocop::AST::Node#parent_module_name 

    With this PR, when Rubocop::AST::Node#parent_module_name_part is executed, it will no longer do non-local exits when a block is evaluated, and evaluating singleton_class or block in Rubocop::AST::Node#parent_module_name will behave as expected.
With this change, this PR aims to resolve the following issue.

rubocop/rubocop#5022
    @sanfrecce-osaka @marcandre
    sanfrecce-osaka authored and marcandre committed Apr 5, 2021
    Copy the full SHA
    1374012 View commit details
    Browse the repository at this point in the history

  2. Refactor tests

    @marcandre
    marcandre committed Apr 5, 2021
    Copy the full SHA
    8be9826 View commit details
    Browse the repository at this point in the history

  3. Add test and tweak processing

    @marcandre
    marcandre committed Apr 5, 2021
    Copy the full SHA
    2cf2701 View commit details
    Browse the repository at this point in the history