Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add argument_type? method to make it easy to recognize argument nodes #15

Merged
merged 1 commit into from Jun 8, 2020
Merged

Add argument_type? method to make it easy to recognize argument nodes #15

merged 1 commit into from Jun 8, 2020

Conversation

tejasbubane
Copy link
Contributor

Closes #11

@tejasbubane tejasbubane mentioned this pull request Jun 1, 2020
Closed
koic
koic reviewed Jun 1, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@tejasbubane
Copy link
Contributor Author

@Drenmi @koic changes done.

marcandre
marcandre requested changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@marcandre marcandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I made a few comments to make it even better

spec/rubocop/ast/node_spec.rb Outdated Show resolved Hide resolved
spec/rubocop/ast/node_spec.rb Outdated Show resolved Hide resolved
spec/rubocop/ast/node_spec.rb Outdated Show resolved Hide resolved
@tejasbubane
Copy link
Contributor Author

@marcandre Changes done.

@marcandre marcandre merged commit f24216a into rubocop:master Jun 8, 2020
@marcandre
Copy link
Contributor

LGTM, thanks!

@tejasbubane tejasbubane deleted the fix-11 branch June 9, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koic koic koic left review comments

@baweaver baweaver baweaver left review comments

@Drenmi Drenmi Drenmi left review comments

@bbatsov bbatsov bbatsov approved these changes

@marcandre marcandre Awaiting requested review from marcandre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing easy way to distinguish argument nodes
6 participants
@tejasbubane @marcandre @koic @bbatsov @baweaver @Drenmi