Only traverse send nodes in def_modifier? #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A send node is a "def modifier" if it's part of a chain of method calls
preceding a method definition. However the previous implementation was
too permissive and matched any method definition in the send node's AST.
In the following example, `include` was considered to be a def modifier:
include Module.new {
def foo
end
}
|
Super! |
|
Oh, nice. I had originally added the changelog entry directly, but I moved it after reading CONTRIBUTING.md and left the link definition in place. I think the instructions are pretty clear, I'm just used to the old way. |
|
👍 Perfect then. |
|
Actually, I released 1.0.1 now :-) |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A send node is a "def modifier" if it's part of a chain of method calls preceding a method definition. However the previous implementation was too permissive and matched any method definition in the send node's AST.
In the following example,
includewas considered to be a def modifier:This is the root cause of the problem fixed in rubocop/rubocop#8653.