Skip to content

Commit

Permalink
Fix a build error (#280)
Browse files Browse the repository at this point in the history
This PR resolves the following CI error with RuboCop 1.35.0:

```console
  1) RuboCop Project requiring all of `lib` with verbose warnings enabled emits no warnings
     Failure/Error: expect(warnings).to eq []

       expected: []
            got: ["/home/runner/work/rubocop-ast/rubocop/lib/rubocop/formatter/html_formatter.rb:6:
warning: base64 wa...l no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.\n"]

       (compared using ==)

       Diff:
       @@ -1 +1,2 @@
       +/home/runner/work/rubocop-ast/rubocop/lib/rubocop/formatter/html_formatter.rb:6: warning:
base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0.
Add base64 to your Gemfile or gemspec.\n

     # ./spec/project_spec.rb:284:in `block (3 levels) in <top (required)>'
```

https://github.com/rubocop/rubocop-ast/actions/runs/8033104014/job/21943241393

It updates RuboCop to 1.57.2, which was finally resolved by rubocop/rubocop#12313.
  • Loading branch information
koic committed Feb 25, 2024
1 parent 6ed1356 commit 7fb6fbe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/rubocop.yml
Expand Up @@ -92,7 +92,7 @@ jobs:
internal_investigation: [null]
include:
- { rubocop: master, ruby: "3.0", os: ubuntu }
- { rubocop: "v1.35.0", ruby: "3.3", os: ubuntu }
- { rubocop: "v1.57.2", ruby: "3.3", os: ubuntu }
steps:
- name: checkout
uses: actions/checkout@v4
Expand Down

0 comments on commit 7fb6fbe

Please sign in to comment.