Skip to content

Commit

Permalink
Fix warning when executing rubocop with bundle exec
Browse files Browse the repository at this point in the history
`check_commit.rake` requires 'English' but when doing `bundle exec rubocop` this file will also be evaluated.

```
earlopain@DESKTOP-PC rubocop-ast]$ RUBYOPT=-w bundle exec rubocop -V
/home/earlopain/Documents/rubocop-ast/rubocop-ast.gemspec:18: warning: global variable `$RS' not initialized
1.62.1 (using Parser 3.3.0.5, rubocop-ast 1.31.2, running on ruby 3.3.0) [x86_64-linux]
  - rubocop-performance 1.20.2
  - rubocop-rspec 2.27.1
```
  • Loading branch information
Earlopain committed Mar 14, 2024
1 parent 00faca9 commit 2b1c46c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Expand Up @@ -2,6 +2,10 @@

## master (unreleased)

### Bug fixes

* [#288](https://github.com/rubocop/rubocop-ast/pull/288): Fix a Ruby warning (`RUBYOPT=-w`) when doing `bundle exec rubocop` during `rubocop-ast` development. ([@Earlopain][])

## 1.31.2 (2024-03-08)

### Bug fixes
Expand Down Expand Up @@ -451,3 +455,4 @@
[@tdeo]: https://github.com/tdeo
[@ydah]: https://github.com/ydah
[@sambostock]: https://github.com/sambostock
[@Earlopain]: https://github.com/Earlopain
2 changes: 1 addition & 1 deletion rubocop-ast.gemspec
Expand Up @@ -15,7 +15,7 @@ Gem::Specification.new do |s|

s.email = 'rubocop@googlegroups.com'
s.files = `git ls-files lib LICENSE.txt README.md`
.split($RS) + %w[
.split($/) + %w[
lib/rubocop/ast/node_pattern/parser.racc.rb
lib/rubocop/ast/node_pattern/lexer.rex.rb
]
Expand Down

0 comments on commit 2b1c46c

Please sign in to comment.