Skip to content

Commit

Permalink
Run internal investigation using master only. Fix disabling
Browse files Browse the repository at this point in the history
  • Loading branch information
marcandre committed Jun 19, 2020
1 parent 8e595c3 commit 2817ae4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/rubocop.yml
Expand Up @@ -66,7 +66,7 @@ jobs:
if: matrix.coverage != true
run: bundle exec rake spec
- name: internal_investigation
if: "matrix.os != 'windows' && matrix.coverage != true"
if: "matrix.os != 'windows' && matrix.coverage != true && matrix.rubocop == 'master'"
run: bundle exec rake internal_investigation
rubocop_specs:
name: >-
Expand Down
4 changes: 2 additions & 2 deletions lib/rubocop/ast/node.rb
Expand Up @@ -505,7 +505,7 @@ def guard_clause?
# So, does the return value of this node matter? If we changed it to
# `(...; nil)`, might that affect anything?
#
# rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity
# rubocop:disable Metrics/MethodLength
def value_used?
# Be conservative and return true if we're not sure.
return false if parent.nil?
Expand All @@ -527,7 +527,7 @@ def value_used?
true
end
end
# rubocop:enable Metrics/MethodLength, Metrics/CyclomaticComplexity
# rubocop:enable Metrics/MethodLength

# Some expressions are evaluated for their value, some for their side
# effects, and some for both.
Expand Down

0 comments on commit 2817ae4

Please sign in to comment.