Fix ConstNode#ancestor? raising NoMethodError when the constant i…

…s not namespaced.
rubocop · Sep 16, 2020 · 0621fd4 · 0621fd4
1 parent c457a21
commit 0621fd4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/rubocop/ast/node/const_node.rb b/lib/rubocop/ast/node/const_node.rb
@@ -28,6 +28,7 @@ def module_name?
 
       # @return [Boolean] if the constant starts with `::` (aka s(:cbase))
       def absolute?
+        return false unless namespace
         each_path.first.cbase_type?
       end
 

diff --git a/spec/rubocop/ast/const_node_spec.rb b/spec/rubocop/ast/const_node_spec.rb
@@ -31,6 +31,20 @@
 
       it { expect(const_node.absolute?).to eq false }
     end
+
+    context 'non-namespaced constant' do
+      let(:source) { 'Foo' }
+
+      it { expect(const_node.absolute?).to eq false }
+    end
+  end
+
+  describe '#relative?' do
+    context 'non-namespaced constant' do
+      let(:source) { 'Foo' }
+
+      it { expect(const_node.relative?).to eq true }
+    end
   end
 
   describe '#each_path' do