Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent attribute missing warnings #3

Closed
wants to merge 1 commit into from

Conversation

HeroProtagonist
Copy link

Fixes rubocop/rubocop#9150

These warnings appear because antora enables them by default. asciidoctor/asciidoctor#3482 (comment)

When the value is set to skip which assciidoctor has as default (as mentioned here https://discuss.asciidoctor.org/skipping-reference-to-missing-attribute-tp7687p7691.html) the warnings are not shown.

Set asciidoctor attribute `attribute-missing` to `skip`. Antora sets it to `warn` by default.
@bbatsov
Copy link
Contributor

bbatsov commented Oct 10, 2021

Hmm, won't this suppress the real problems as well, though? I think I already fixed the cause of the warnings at some point in the past, but they are still in the build output because we keep building the old versions of the docs as well (where the problem is not fixed).

Seems the only good solution would be to drop the old versions from the build, so they don't generate a lot of noise, but that might break some linking. Tough situation. //cc @rubocop/rubocop-core

@koic
Copy link
Member

koic commented Oct 11, 2021

Seems the only good solution would be to drop the old versions from the build, so they don't generate a lot of noise, but that might break some linking.

I think it's possible to drop old versions of the build, leaving a few generations. The reason is as follows.

I'm not sure how many generations to leave. 3 to 5 generations may be enough. But I'm not confident.

Anyway, I don't have a strong opinion, so I'm interested in other opinions as well 😃

@koic
Copy link
Member

koic commented Feb 28, 2023

Hmm, won't this suppress the real problems as well, though?

I'm going to close this proposal because I agree with this opinion. Thank you.

@koic koic closed this Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings when building the docs
3 participants