Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rubocop-capybara extension #12

Closed
wants to merge 2 commits into from

Conversation

pirj
Copy link
Member

@pirj pirj commented Dec 29, 2022

We've extracted some cops from rubocop-rspec to rubocop-capybara.

Please accept my apologies for the lack of fundamental knowledge how docs.rubocop.org function. Please help me to shape this PR, and I'll be happy to send the next ones on my own, as we plan to extract rubocop-factory_girl and rubocop-rspec-rails in the near future.

When a new version of rubocop-capybara is released, will it automatically be published with those changes to https://docs.rubocop.org/rubocop-capybara?

@pirj pirj mentioned this pull request Dec 29, 2022
5 tasks
@ydah
Copy link
Member

ydah commented Jan 10, 2023

@bbatsov , @koic sorry to bother you. May I ask you to check the PR here?

@koic
Copy link
Member

koic commented Jan 10, 2023

When a new version of rubocop-capybara is released, will it automatically be published with those changes to https://docs.rubocop.org/rubocop-capybara?

It is not automatically generated by release. This site will need to be rebuilt if the git tag is updated:
https://github.com/rubocop/docs.rubocop.org#building-the-site

Releases that do not require document updates do not require a rebuild.

May I ask you to check the PR here?

Due to conflicts files, I will cherry-pick and generate the documentation this time.

@koic
Copy link
Member

koic commented Jan 10, 2023

I will be closing this as it has been applied to the site.
https://docs.rubocop.org/rubocop-capybara/2.17/index.html

Thank you.

@koic koic closed this Jan 10, 2023
@ydah
Copy link
Member

ydah commented Jan 10, 2023

@koic Thank you. I appreciate it.

@pirj pirj deleted the add-rubocop-capybara branch January 10, 2023 10:35
@pirj
Copy link
Member Author

pirj commented Jan 10, 2023

Thank you, @koic !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants