Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete gem SafeYAML compatibility #9004

Merged
merged 1 commit into from Nov 7, 2020

Conversation

marcandre
Copy link
Contributor

AFAIK, there is no longer any reason to use SafeYAML.

This is what was causing issues on ruby-head, the gem is incompatible with keyword parameters.

@mergify mergify bot merged commit 64e9b8c into rubocop:master Nov 7, 2020
@koic koic mentioned this pull request Nov 7, 2020
@aav7fl
Copy link

aav7fl commented Nov 12, 2020

@marcandre Would it have been better to warn instead of raising an error?

I understand the importance of letting users know they should remove that dependency if they were using RuboCop in isolation.

But I have another project (Jekyll) that I use to build my site before testing. Jekyll is pulling in SafeYAML during the build portion which then breaks my RuboCop tests.

Or should I be isolating my build/test portions and uninstalling gems between steps?

Suggested changes: #9035

@aav7fl aav7fl mentioned this pull request Nov 12, 2020
8 tasks
@marcandre marcandre deleted the safeyaml branch November 12, 2020 16:24
@marcandre
Copy link
Contributor Author

Let's discuss in #9035 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants