Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI broken on master #8103

Closed
marcandre opened this issue Jun 6, 2020 · 5 comments
Closed

CI broken on master #8103

marcandre opened this issue Jun 6, 2020 · 5 comments

Comments

@marcandre
Copy link
Contributor

Is anyone looking at solving our failing CI?

spec/rubocop/config_loader_spec.rb:1222 and
spec/rubocop/config_loader_spec.rb:1233
are failing on CircleCI.

Very strange to me that the almost identical spec on line 1268 does not fail.
Those 3 specs are the only ones using in_its_own_process_with
@marcandre marcandre added the high priority A ticket considered important by RuboCop's Core Team label Jun 6, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 7, 2020

I'm guessing those failures are related with some upstream Ruby changes. I wouldn't consider them a release blocker, but obviously it'd be great if we managed to sort them out.

@marcandre marcandre mentioned this issue Jun 8, 2020
Merged
@marcandre
Copy link
Contributor Author

I've disabled those two specs on the two jobs so at least the CI is green again.

@koic
Copy link
Member

koic commented Jun 8, 2020

Thank you! I think these surveys can be done separately 👍

@marcandre
Copy link
Contributor Author

It would be good to see what's up with ruby-head though, might be a regression they are not aware of.

@marcandre marcandre removed the high priority A ticket considered important by RuboCop's Core Team label Jun 9, 2020
@koic
Copy link
Member

koic commented Nov 7, 2020

This issue has been resolved by #9004.

@koic koic closed this as completed Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@koic @marcandre @bbatsov