[Fix rubocop-hq/rubocop-performance#95] Fix to return correct info from multi-line regexp #7661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buehmann
reviewed
Jan 20, 2020
Tietew
force-pushed
the
ast_regexp_multiline_fix
branch
from
78a739f
to
b7515ad
Compare
|
@buehmann Fixed and force-pushed. |
|
Can you add a changelog entry to |
…multi-line regexp Fixes rubocop/rubocop-performance#95. This PR fixes `RuboCop::AST::RegexpNode` to return correct information from multi-line regexp. - `#regopt` - returns last node instead of checking first node. - `#content` - joins all child string nodes instead of returning first node.
Tietew
force-pushed
the
ast_regexp_multiline_fix
branch
from
b7515ad
to
479e733
Compare
|
@koic Done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rubocop/rubocop-performance#95.
This PR fixes
RuboCop::AST::RegexpNodeto return correct informationfrom multi-line regexp.
#regopt- find regopt node instead of checking first node.#content- join all child string nodes instead of returning first node.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.