Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--safe-autocorrect typo? #8252

Closed
ybiquitous opened this issue Jul 7, 2020 · 1 comment · Fixed by #8254
Closed

--safe-autocorrect typo? #8252

ybiquitous opened this issue Jul 7, 2020 · 1 comment · Fixed by #8254
Labels
bug

Comments

@ybiquitous
Copy link
Contributor

Hi, I found the --safe-auto-correct option has been renamed to --safe-autocorrect since v0.87.0.
It looks like a typo to me.

Expected behavior

rubocop --safe-auto-correct should succeed.

Actual behavior

$ rubocop --safe-auto-correct
invalid option: --safe-auto-correct
Did you mean?  safe-autocorrect
For usage information, use --help

Steps to reproduce the problem

$ gem install rubocop:0.87.0
...

$ rubocop --safe-auto-correct
invalid option: --safe-auto-correct
...

RuboCop version

Include the output of rubocop -V or bundle exec rubocop -V if using Bundler. Here's an example:

$ rubocop -V
0.87.0 (using Parser 2.7.1.4, rubocop-ast 0.1.0, running on ruby 2.7.1 x86_64-darwin19)
@koic koic added the bug label Jul 7, 2020
koic added a commit to koic/rubocop that referenced this issue Jul 7, 2020
@koic
[Fix rubocop#8252] Fix a typo for --safe-auto-correct command line …
708fdd4 
…option

Fixes rubocop#8252.

This PR fixes a command line option name from `--safe-autocorrect`
to `--safe-auto-correct`, which is compatible with RuboCop 0.66 and lower.

Before:

```console
% bundle exec ./exe/rubocop --safe-auto-correct
invalid option: --safe-auto-correct
Did you mean?  safe-autocorrect
For usage information, use --help
```

After:

```console
% bundle exec ./exe/rubocop --safe-auto-correct
--safe-auto-correct is deprecated; use --auto-correct
Inspecting 1082 files
```
@koic koic mentioned this issue Jul 7, 2020
Merged
8 tasks
bbatsov pushed a commit that referenced this issue Jul 7, 2020
@koic @bbatsov
[Fix #8252] Fix a typo for --safe-auto-correct command line option
4c06394 
Fixes #8252.

This PR fixes a command line option name from `--safe-autocorrect`
to `--safe-auto-correct`, which is compatible with RuboCop 0.66 and lower.

Before:

```console
% bundle exec ./exe/rubocop --safe-auto-correct
invalid option: --safe-auto-correct
Did you mean?  safe-autocorrect
For usage information, use --help
```

After:

```console
% bundle exec ./exe/rubocop --safe-auto-correct
--safe-auto-correct is deprecated; use --auto-correct
Inspecting 1082 files
```
@ybiquitous
Copy link
Contributor Author

Thank you!

@MaxLap MaxLap mentioned this issue Nov 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #8252] Fix a typo for --safe-auto-correct command line option koic/rubocop
2 participants
@koic @ybiquitous