Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Rails/DynamicFindBy #346

Merged
merged 1 commit into from Sep 14, 2020

Conversation

koic
Copy link
Member

@koic koic commented Sep 7, 2020

This PR fixes a false positive for Rails/DynamicFindBy when any of the arguments are splat argument.

% cat example.rb
find_by_scan(*args)

% bundle exec rubocop -a example.rb
(snip)

Inspecting 1 file
E

Offenses:

example.rb:1:1: C: [Corrected] Rails/DynamicFindBy: Use find_by instead
of dynamic find_by_scan.
find_by_scan(*args)
^^^^^^^^^^^^^^^^^^^
example.rb:1:15: E: Lint/Syntax: unexpected token tSTAR
(Using Ruby 2.7 parser; configure using TargetRubyVersion parameter,
under AllCops)
find_by(scan: *args)
              ^

1 file inspected, 2 offenses detected, 1 offense corrected

% cat example.rb
find_by(scan: *args)

% ruby -c example.rb
example.rb:1: syntax error, unexpected *
find_by(scan: *args)

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic force-pushed the fix_false_positive_for_dynamic_find_by branch 2 times, most recently from 7b31f44 to 73b3180 Compare September 13, 2020 06:11
This PR fixes a false positive for `Rails/DynamicFindBy`
when any of the arguments are splat argument.

```console
% cat example.rb
find_by_scan(*args)

% bundle exec rubocop -a example.rb
(snip)

Inspecting 1 file
E

Offenses:

example.rb:1:1: C: [Corrected] Rails/DynamicFindBy: Use find_by instead
of dynamic find_by_scan.
find_by_scan(*args)
^^^^^^^^^^^^^^^^^^^
example.rb:1:15: E: Lint/Syntax: unexpected token tSTAR
(Using Ruby 2.7 parser; configure using TargetRubyVersion parameter,
under AllCops)
find_by(scan: *args)
              ^

1 file inspected, 2 offenses detected, 1 offense corrected

% cat example.rb
find_by(scan: *args)

% ruby -c example.rb
example.rb:1: syntax error, unexpected *
find_by(scan: *args)
```
@koic koic force-pushed the fix_false_positive_for_dynamic_find_by branch from 73b3180 to 01036ab Compare September 13, 2020 07:13
@koic koic merged commit 3ec7cda into rubocop:master Sep 14, 2020
@koic koic deleted the fix_false_positive_for_dynamic_find_by branch September 14, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant