NodePattern: Use param === node to match params.
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcandre
force-pushed
the
nodepatternmatch
branch
from
726a5c9
to
3080ea1
Compare
marcandre
force-pushed
the
nodepatternmatch
branch
from
3080ea1
to
0e6ed2c
Compare
pirj
approved these changes
Jun 11, 2020
| @@ -374,6 +374,41 @@ def_node_matcher :initializing_with_user?, <<~PATTERN | |||
| PATTERN | |||
| ---- | |||
|
|
|||
| == `%` for arguments | |||
There was a problem hiding this comment.
👍 I was looking for this section today.
pirj
added a commit
to rubocop/rubocop-rspec
that referenced
this pull request
Jun 11, 2020
#804 (comment) Support introduced in rubocop/rubocop-ast#31 Presumably this will land in RuboCop 1.0 or 1.0.1 worst case.
3 tasks
|
I'll check about accepting |
pirj
added a commit
to rubocop/rubocop-rspec
that referenced
this pull request
Jul 15, 2020
#804 (comment) Support introduced in rubocop/rubocop-ast#31 Presumably this will land in RuboCop 1.0 or 1.0.1 worst case.
pirj
added a commit
to rubocop/rubocop-rspec
that referenced
this pull request
Jul 15, 2020
#804 (comment) Support introduced in rubocop/rubocop-ast#31 Presumably this will land in RuboCop 1.0 or 1.0.1 worst case.
pirj
added a commit
to rubocop/rubocop-rspec
that referenced
this pull request
Jul 15, 2020
#804 (comment) Support introduced in rubocop/rubocop-ast#31 Presumably this will land in RuboCop 1.0 or 1.0.1 worst case.
pirj
added a commit
to rubocop/rubocop-rspec
that referenced
this pull request
Jul 15, 2020
#804 (comment) Support introduced in rubocop/rubocop-ast#31 Presumably this will land in RuboCop 1.0 or 1.0.1 worst case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to be
node == param.For most classes,
===is the same as==, and==is symmetric, so this has no impact, except forRegexp,Class,Proc,Set,Range, none of which can exist in the AST.This opens many cool patterns though:
(hash <(pair (_ %1) $_)>...)called with a regexp to match a symbol/string key(send _ %1 ...)called withSetof possible method names to match.etc.
Thanks to @pirj for bringing this to my attention